Change in meta-telephony[201705]: libosmo-netif: workaround oe-core forcing fail of sctp.h autoconf check

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Thu Jan 7 13:37:34 UTC 2021


Hello pespin,

I'd like you to do a code review. Please visit

    https://gerrit.osmocom.org/c/meta-telephony/+/22023

to review the following change.


Change subject: libosmo-netif: workaround oe-core forcing fail of sctp.h autoconf check
......................................................................

libosmo-netif: workaround oe-core forcing fail of sctp.h autoconf check

oe-core is currently (pyro and current master) forcing non-availability
of netinet/sctp.h header file through autoconf's export CONFIG_SITE
pointing to files in meta/site/, which contain:
ac_cv_header_netinet_sctp_h=${ac_cv_header_netinet_sctp_h=no}

As a result, netinet/sctp.h is not found despite DEPENDS="lksctp-tools"
and the file being available correctly under recipe-sysroot/ and finally
configure fails with AC_MSG_ERROR().

It was confirmed by OE devs that those lines should not be there, and a
patch has been submitted:
https://patchwork.openembedded.org/patch/168892/

Since it's not available in pyro nor latest release, let's workaround it
in our recipe to make sure it works with older versions of OE.

Change-Id: Ide91e96648881a0c6d415d727a14c2ef913fb180
---
M recipes-osmocom/libosmo-netif/libosmo-netif.inc
1 file changed, 4 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/meta-telephony refs/changes/23/22023/1

diff --git a/recipes-osmocom/libosmo-netif/libosmo-netif.inc b/recipes-osmocom/libosmo-netif/libosmo-netif.inc
index 0a51dfc..7098c42 100644
--- a/recipes-osmocom/libosmo-netif/libosmo-netif.inc
+++ b/recipes-osmocom/libosmo-netif/libosmo-netif.inc
@@ -12,4 +12,8 @@
     "
 PACKAGECONFIG[libsctp] = "--enable-libsctp,--disable-libsctp,lksctp-tools,"
 
+# Workaround to oe-core meta/site/* CONFIG_SITE files passed to autoconf forcing unavailability of netinet/sctp.h.
+# Patch fixing issue upstream: https://patchwork.openembedded.org/patch/168892/
+CACHED_CONFIGUREVARS += "${@bb.utils.contains('PACKAGECONFIG', 'libsctp', 'ac_cv_header_netinet_sctp_h=yes', '',d)}"
+
 inherit autotools pkgconfig

-- 
To view, visit https://gerrit.osmocom.org/c/meta-telephony/+/22023
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: meta-telephony
Gerrit-Branch: 201705
Gerrit-Change-Id: Ide91e96648881a0c6d415d727a14c2ef913fb180
Gerrit-Change-Number: 22023
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210107/282bd7a6/attachment.htm>


More information about the gerrit-log mailing list