Change in osmo-bts[master]: osmo-bts-trx: vty: clarify and improve some deprecation messages

[fixeria]

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/21990 )

Change subject: osmo-bts-trx: vty: clarify and improve some deprecation messages
......................................................................

osmo-bts-trx: vty: clarify and improve some deprecation messages

Change-Id: I22b69eccfa50d178bd36bf770f7158ec441c9923
Related: SYS#4918
---
M src/osmo-bts-trx/trx_vty.c
1 file changed, 8 insertions(+), 4 deletions(-)

Approvals:
  laforge: Looks good to me, but someone else must approve
  pespin: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/osmo-bts-trx/trx_vty.c b/src/osmo-bts-trx/trx_vty.c
index 55a7ee7..49403d4 100644
--- a/src/osmo-bts-trx/trx_vty.c
+++ b/src/osmo-bts-trx/trx_vty.c
@@ -196,7 +196,8 @@
 	"Enable MS power control loop\nTarget RSSI value (transceiver specific, "
 	"should be 6dB or more above noise floor)\n")
 {
-	vty_out (vty, "'osmotrx ms-power-loop' is deprecated, use 'uplink-power-target' instead%s", VTY_NEWLINE);
+	vty_out(vty, "'%s' is deprecated, MS Power Control is now managed by BSC%s",
+		self->string, VTY_NEWLINE);
 
 	g_bts->ul_power_ctrl.target_dbm = atoi(argv[0]);
 
@@ -207,7 +208,8 @@
 	"no osmotrx ms-power-loop",
 	NO_STR OSMOTRX_STR "Disable MS power control loop\n")
 {
-	vty_out (vty, "'no osmotrx ms-power-loop' is deprecated, use of BTS control loop is managed by BSC%s", VTY_NEWLINE);
+	vty_out(vty, "'%s' is deprecated, MS Power Control is now managed by BSC%s",
+		self->string, VTY_NEWLINE);
 
 	return CMD_SUCCESS;
 }
@@ -216,7 +218,8 @@
 	"osmotrx timing-advance-loop", OSMOTRX_STR
 	"Enable timing advance control loop\n")
 {
-	vty_out (vty, "'osmotrx timing-advance-loop' is deprecated, ta control is now active by default%s", VTY_NEWLINE);
+	vty_out(vty, "'%s' is deprecated, Timing Advance loop is now active by default%s",
+		self->string, VTY_NEWLINE);
 
 	return CMD_SUCCESS;
 }
@@ -224,7 +227,8 @@
 	"no osmotrx timing-advance-loop",
 	NO_STR OSMOTRX_STR "Disable timing advance control loop\n")
 {
-	vty_out (vty, "'no osmotrx timing-advance-loop' is deprecated, ta control is now active by default%s", VTY_NEWLINE);
+	vty_out(vty, "'%s' is deprecated, Timing Advance loop is now active by default%s",
+		self->string, VTY_NEWLINE);
 
 	return CMD_SUCCESS;
 }

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/21990
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I22b69eccfa50d178bd36bf770f7158ec441c9923
Gerrit-Change-Number: 21990
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210107/f8fe4ddc/attachment.htm>