Change in osmo-sgsn[master]: Fix gbproxy_sgsn_by_tlli wraparound

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Wed Jan 6 12:32:59 UTC 2021


laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/21959 )

Change subject: Fix gbproxy_sgsn_by_tlli wraparound
......................................................................

Fix gbproxy_sgsn_by_tlli wraparound

Change-Id: I74ecb655f4d433f7ac14d00d934d237325aab606
Related: SYS#4865, OS#4472
---
M src/gbproxy/gb_proxy_peer.c
1 file changed, 2 insertions(+), 1 deletion(-)

Approvals:
  pespin: Looks good to me, but someone else must approve
  laforge: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/gbproxy/gb_proxy_peer.c b/src/gbproxy/gb_proxy_peer.c
index 544eb5f..d2ddfc1 100644
--- a/src/gbproxy/gb_proxy_peer.c
+++ b/src/gbproxy/gb_proxy_peer.c
@@ -534,8 +534,9 @@
 		i++;
 	}
 	// Start again from the beginning
+	i = 0;
 	llist_for_each_entry(sgsn, &cfg->sgsns, list) {
-		if (i > index) {
+		if (i >= index) {
 			break;
 		} else if (sgsn->pool.allow_attach) {
 			return sgsn;

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/21959
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Change-Id: I74ecb655f4d433f7ac14d00d934d237325aab606
Gerrit-Change-Number: 21959
Gerrit-PatchSet: 2
Gerrit-Owner: daniel <dwillmann at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <daniel at totalueberwachung.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210106/67379e6d/attachment.htm>


More information about the gerrit-log mailing list