Change in pysim[master]: sysmoISIM-SJA2: Add support for programming IPv4 address for Home ePD...

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Tue Jan 5 14:23:33 UTC 2021


laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/21870 )

Change subject: sysmoISIM-SJA2: Add support for programming IPv4 address for Home ePDG Identifier
......................................................................

sysmoISIM-SJA2: Add support for programming IPv4 address for Home ePDG Identifier

This commit allows programming of IPv4 or FQDN in EF.ePDGId

Example:

./pySim-prog.py -p 0 -x 001 -y 01 -s 8988211900000000004 -i 001011234567895 -k 8baf473f2f8fd09487cccbd7097c6862 --op 11111111111111111111111111111111 -o 8E27B6AF0E692E750F32667A3B14605D -a 85524953 -n isim.test --msisdn 0598765432100 --epdgid 172.24.15.20 --pcscf pcscf.testims.org --ims-hdomain testims.org

Change-Id: I10a708d3e0c3ae398c942e3529e364dfe4bb23e7
---
M pySim/cards.py
1 file changed, 4 insertions(+), 1 deletion(-)

Approvals:
  Jenkins Builder: Verified
  laforge: Looks good to me, approved



diff --git a/pySim/cards.py b/pySim/cards.py
index d60b27a..b7be6e8 100644
--- a/pySim/cards.py
+++ b/pySim/cards.py
@@ -276,7 +276,10 @@
 	def update_epdgid(self, epdgid):
 		size = self._scc.binary_size(EF_USIM_ADF_map['ePDGId']) * 2
 		if len(epdgid) > 0:
-			epdgid_tlv = rpad(enc_addr_tlv(epdgid), size)
+			addr_type = get_addr_type(epdgid)
+			if addr_type == None:
+				raise ValueError("Unknown ePDG Id address type or invalid address provided")
+			epdgid_tlv = rpad(enc_addr_tlv(epdgid, ('%02x' % addr_type)), size)
 		else:
 			epdgid_tlv = rpad('ff', size)
 		data, sw = self._scc.update_binary(

-- 
To view, visit https://gerrit.osmocom.org/c/pysim/+/21870
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I10a708d3e0c3ae398c942e3529e364dfe4bb23e7
Gerrit-Change-Number: 21870
Gerrit-PatchSet: 3
Gerrit-Owner: herlesupreeth <herlesupreeth at gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210105/a1abfbbf/attachment.htm>


More information about the gerrit-log mailing list