Change in osmo-bts[master]: l1sap: fix: enable UL SACCH repetition if RxQual threshold is 0

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

fixeria gerrit-no-reply at lists.osmocom.org
Tue Jan 5 12:47:37 UTC 2021


fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/21938 )

Change subject: l1sap: fix: enable UL SACCH repetition if RxQual threshold is 0
......................................................................

l1sap: fix: enable UL SACCH repetition if RxQual threshold is 0

It is expected that setting RxQual threshold to 0 would make the
L1SAP logic enable repetition for both Uplink SACCH and Downlink
FACCH unconditionally.  However, this was only valid for the
later.  Let's add the missing check and make it consistent.

Change-Id: Ia44a134e7f28ea990798d1b79c87b644504c0876
Related: SYS#5114
---
M src/common/l1sap.c
1 file changed, 6 insertions(+), 0 deletions(-)

Approvals:
  Jenkins Builder: Verified
  fixeria: Looks good to me, approved
  laforge: Looks good to me, but someone else must approve
  dexter: Looks good to me, but someone else must approve



diff --git a/src/common/l1sap.c b/src/common/l1sap.c
index 33d10a5..48773f1 100644
--- a/src/common/l1sap.c
+++ b/src/common/l1sap.c
@@ -1408,6 +1408,12 @@
 	if (!lchan->repeated_acch_capability.ul_sacch)
 		return;
 
+	/* Threshold disabled (repetition is always on) */
+	if (lchan->repeated_acch_capability.rxqual == 0) {
+		lchan->repeated_ul_sacch_active = true;
+		return;
+	}
+
 	/* convert from RXQUAL value to ber10k vale,
 	 * see also GSM 05.08, section 8.2.4 */
 	static const uint16_t ber10k_by_rxqual_upper[] =

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/21938
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: Ia44a134e7f28ea990798d1b79c87b644504c0876
Gerrit-Change-Number: 21938
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Assignee: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210105/47c8f1d0/attachment.htm>


More information about the gerrit-log mailing list