Change in osmo-bsc[master]: smscb: Fix adding of SMSCB messages when no message with lower period...

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Mon Jan 4 21:48:03 UTC 2021


laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/21921 )

Change subject: smscb: Fix adding of SMSCB messages when no message with lower period exists
......................................................................

smscb: Fix adding of SMSCB messages when no message with lower period exists

Adding SMSCB messages to a BTS so far only worked if there were
existing messages with a lower scheduling period than the new message.

Before this patch, it fails for new messages if they are of equal or
lower scheduling period than the existing messages.

Change-Id: I69a05b22200b3a1ee406b0673553e135603d723b
---
M src/osmo-bsc/smscb.c
1 file changed, 2 insertions(+), 0 deletions(-)

Approvals:
  laforge: Looks good to me, approved
  pespin: Looks good to me, but someone else must approve
  Jenkins Builder: Verified



diff --git a/src/osmo-bsc/smscb.c b/src/osmo-bsc/smscb.c
index 8ce962a..542453c 100644
--- a/src/osmo-bsc/smscb.c
+++ b/src/osmo-bsc/smscb.c
@@ -110,6 +110,8 @@
 			return;
 		}
 	}
+	/* we didn't find any messages with longer period than us, insert us at tail */
+	llist_add_tail(&new->list, &cstate->messages);
 }
 
 /* stringify a SMSCB for logging */

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/21921
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I69a05b22200b3a1ee406b0673553e135603d723b
Gerrit-Change-Number: 21921
Gerrit-PatchSet: 3
Gerrit-Owner: laforge <laforge at osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann at sysmocom.de>
Gerrit-Reviewer: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210104/9fb44a86/attachment.htm>


More information about the gerrit-log mailing list