This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
fixeria gerrit-no-reply at lists.osmocom.orgfixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/21907 ) Change subject: power_control: generalize the arguments of do_pf_ewma() ...................................................................... Patch Set 4: (1 comment) https://gerrit.osmocom.org/c/osmo-bts/+/21907/4/src/common/power_control.c File src/common/power_control.c: https://gerrit.osmocom.org/c/osmo-bts/+/21907/4/src/common/power_control.c@76 PS4, Line 76: if (*Avg100 == 0) { > iiuc Avg100 can also be 0 after first run. […] The point of weighting is that you take a part of the recent measurement value, and a part of the previous one. So their sum matters. During the first run, outputting the value as-is seems reasonable to me, otherwise if e.g. A=50 (default) and Val=-80 you would get Avg=-40, so the power will be increased or decreased for no reason. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/21907 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I439c00b394da670e314f217b3246cc85ce8213c6 Gerrit-Change-Number: 21907 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin at sysmocom.de> Gerrit-Comment-Date: Mon, 04 Jan 2021 10:43:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin at sysmocom.de> Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210104/0e283237/attachment.htm>