Change in libosmocore[master]: gsm_08_58: add flexible array member to 'struct ipac_preproc_ave_cfg'

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

fixeria gerrit-no-reply at lists.osmocom.org
Sun Jan 3 22:23:11 UTC 2021


fixeria has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/21874 )

Change subject: gsm_08_58: add flexible array member to 'struct ipac_preproc_ave_cfg'
......................................................................

gsm_08_58: add flexible array member to 'struct ipac_preproc_ave_cfg'

Some averaging methods may have additional parameters, so let's
make it easier to access them for the API user.

Change-Id: I2f4ed56837dd479dbbd10c0a7df0ed7565d3946a
Related: SYS#4918
---
M TODO-RELEASE
M include/osmocom/gsm/protocol/gsm_08_58.h
2 files changed, 3 insertions(+), 0 deletions(-)

Approvals:
  laforge: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/TODO-RELEASE b/TODO-RELEASE
index 33e27af..e8fb32b 100644
--- a/TODO-RELEASE
+++ b/TODO-RELEASE
@@ -9,5 +9,6 @@
 #library	what			description / commit summary line
 libosmogsm	new API			gsm0808_create_sapi_reject_cause() with cause argument
 libosmogsm	ABI change		struct osmo_gprs_cell_options size changed (new field at the end)
+libosmogsm	API change		struct ipac_preproc_ave_cfg: new zero-sized flexible array member at end
 libosmovty	ABI change		struct cmd_element: add a field for program specific attributes
 libosmovty	ABI change		struct vty_app_info: optional program specific attributes description
diff --git a/include/osmocom/gsm/protocol/gsm_08_58.h b/include/osmocom/gsm/protocol/gsm_08_58.h
index 046d358..e9c14e6 100644
--- a/include/osmocom/gsm/protocol/gsm_08_58.h
+++ b/include/osmocom/gsm/protocol/gsm_08_58.h
@@ -775,10 +775,12 @@
 		reserved:1;
 	uint8_t h_reqt:5,
 		ave_method:3;
+	uint8_t params[0];
 #elif OSMO_IS_BIG_ENDIAN
 /* auto-generated from the little endian part above (libosmocore/contrib/struct_endianess.py) */
 	uint8_t reserved:1, param_id:2, h_reqave:5;
 	uint8_t ave_method:3, h_reqt:5;
+	uint8_t params[0];
 #endif
 }__attribute__ ((packed));
 

-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/21874
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I2f4ed56837dd479dbbd10c0a7df0ed7565d3946a
Gerrit-Change-Number: 21874
Gerrit-PatchSet: 3
Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210103/72b5c9df/attachment.htm>


More information about the gerrit-log mailing list