Change in libosmocore[master]: cbsp: Fix parsing DCS in decode of WRITE-REPLACE

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Sun Jan 3 17:09:00 UTC 2021


laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/21919 )

Change subject: cbsp: Fix parsing DCS in decode of WRITE-REPLACE
......................................................................

cbsp: Fix parsing DCS in decode of WRITE-REPLACE

The encoder generates the DCS IE, but the decoder forgot to parse it :/

Change-Id: I05d489f91a2cc5df372e8e695126659eedac9485
---
M src/gsm/cbsp.c
1 file changed, 1 insertion(+), 0 deletions(-)

Approvals:
  laforge: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/gsm/cbsp.c b/src/gsm/cbsp.c
index 2037f7c..2c7a7b7 100644
--- a/src/gsm/cbsp.c
+++ b/src/gsm/cbsp.c
@@ -678,6 +678,7 @@
 		out->u.cbs.category = *TLVP_VAL(tp, CBSP_IEI_CATEGORY);
 		out->u.cbs.rep_period = tlvp_val16be(tp, CBSP_IEI_REP_PERIOD);
 		out->u.cbs.num_bcast_req = tlvp_val16be(tp, CBSP_IEI_NUM_BCAST_REQ);
+		out->u.cbs.dcs = *TLVP_VAL(tp, CBSP_IEI_DCS);
 		num_of_pages = *TLVP_VAL(tp, CBSP_IEI_NUM_OF_PAGES);
 		if (num_of_pages < 1)
 			return -EINVAL;

-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/21919
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I05d489f91a2cc5df372e8e695126659eedac9485
Gerrit-Change-Number: 21919
Gerrit-PatchSet: 2
Gerrit-Owner: laforge <laforge at osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210103/20a4848d/attachment.htm>


More information about the gerrit-log mailing list