Change in osmo-ttcn3-hacks[master]: hlr: Get rid of module param mp_hlr_supports_dgsm

[pespin]

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/23120 )

Change subject: hlr: Get rid of module param mp_hlr_supports_dgsm
......................................................................

hlr: Get rid of module param mp_hlr_supports_dgsm

This param is not needed anymore since new releases used in -latest don't
need to disable it.

Change-Id: I484267c169646310564bd6d9cd13a196b61400e4
Related: OS#5042
---
M hlr/HLR_Tests.cfg
M hlr/HLR_Tests.ttcn
2 files changed, 6 insertions(+), 14 deletions(-)

Approvals:
  Jenkins Builder: Verified
  fixeria: Looks good to me, approved



diff --git a/hlr/HLR_Tests.cfg b/hlr/HLR_Tests.cfg
index 1ab6e87..7416362 100644
--- a/hlr/HLR_Tests.cfg
+++ b/hlr/HLR_Tests.cfg
@@ -12,7 +12,6 @@
 
 
 [MODULE_PARAMETERS]
-HLR_Tests.mp_hlr_supports_dgsm := true
 
 [MAIN_CONTROLLER]
 
diff --git a/hlr/HLR_Tests.ttcn b/hlr/HLR_Tests.ttcn
index ea450b3..959c680 100644
--- a/hlr/HLR_Tests.ttcn
+++ b/hlr/HLR_Tests.ttcn
@@ -70,9 +70,6 @@
 	/* emulated GSUP server (second HLR) */
 	charstring mp_hlr_ts_ip := "127.0.0.99";
 	integer mp_hlr_ts_port := 4222;
-
-	/* drop after osmo-hlr release > 1.2.0 */
-	boolean mp_hlr_supports_dgsm := true;
 };
 
 type record HlrSubscrAud2G {
@@ -154,9 +151,7 @@
 	map(self:VTY, system:VTY);
 	f_vty_set_prompts(VTY);
 	f_vty_transceive(VTY, "enable");
-	if (mp_hlr_supports_dgsm) {
-		f_vty_config(VTY, "mslookup", "no mdns bind");
-	}
+	f_vty_config(VTY, "mslookup", "no mdns bind");
 }
 
 private altstep as_Tguard() runs on test_CT {
@@ -1973,13 +1968,11 @@
 	execute( TC_subscr_create_on_demand_ul() );
 	execute( TC_subscr_create_on_demand_sai() );
 
-	if (mp_hlr_supports_dgsm) {
-		execute( TC_MSLookup_mDNS_service_other_home() );
-		execute( TC_MSLookup_GSUP_proxy() );
-		execute( TC_MSLookup_mDNS_service_GSUP_HLR_home() );
-		execute( TC_MSLookup_mDNS_service_GSUP_HLR_proxy() );
-		execute( TC_MSLookup_mDNS_service_other_proxy() );
-	}
+	execute( TC_MSLookup_mDNS_service_other_home() );
+	execute( TC_MSLookup_GSUP_proxy() );
+	execute( TC_MSLookup_mDNS_service_GSUP_HLR_home() );
+	execute( TC_MSLookup_mDNS_service_GSUP_HLR_proxy() );
+	execute( TC_MSLookup_mDNS_service_other_proxy() );
 };
 
 };

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/23120
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I484267c169646310564bd6d9cd13a196b61400e4
Gerrit-Change-Number: 23120
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210226/707b9fb5/attachment.htm>