Change in osmo-pcu[master]: bts: Count TBF TS allocation failure

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

pespin gerrit-no-reply at lists.osmocom.org
Fri Feb 26 10:21:02 UTC 2021


pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/23106 )

Change subject: bts: Count TBF TS allocation failure
......................................................................

bts: Count TBF TS allocation failure

Related: OS#2282
Change-Id: I0696bf77364bd31b96c00614a58ce66809683d1c
---
M src/bts.cpp
M src/bts.h
M src/tbf.cpp
3 files changed, 4 insertions(+), 0 deletions(-)

Approvals:
  Jenkins Builder: Verified
  fixeria: Looks good to me, approved



diff --git a/src/bts.cpp b/src/bts.cpp
index 11aef3f..8d1fb3f 100644
--- a/src/bts.cpp
+++ b/src/bts.cpp
@@ -100,6 +100,7 @@
 	{ "tbf:reused",			"TBF Reused           "},
 	{ "tbf:alloc:algo-a",		"TBF Alloc Algo A     "},
 	{ "tbf:alloc:algo-b",		"TBF Alloc Algo B     "},
+	{ "tbf:alloc:failed",		"TBF Alloc Failure    "},
 	{ "rlc:sent",			"RLC Sent             "},
 	{ "rlc:resent",			"RLC Resent           "},
 	{ "rlc:restarted",		"RLC Restarted        "},
diff --git a/src/bts.h b/src/bts.h
index 90367ac..d321b8d 100644
--- a/src/bts.h
+++ b/src/bts.h
@@ -87,6 +87,7 @@
 	CTR_TBF_REUSED,
 	CTR_TBF_ALLOC_ALGO_A,
 	CTR_TBF_ALLOC_ALGO_B,
+	CTR_TBF_ALLOC_FAIL,
 	CTR_RLC_SENT,
 	CTR_RLC_RESENT,
 	CTR_RLC_RESTARTED,
diff --git a/src/tbf.cpp b/src/tbf.cpp
index b1121bb..2f58375 100644
--- a/src/tbf.cpp
+++ b/src/tbf.cpp
@@ -335,6 +335,7 @@
 	/* if no resource */
 	if (rc < 0) {
 		LOGPTBF(this, LOGL_ERROR, "No resource after update???\n");
+		bts_do_rate_ctr_inc(bts, CTR_TBF_ALLOC_FAIL);
 		return -rc;
 	}
 
@@ -754,6 +755,7 @@
 		LOGPTBF(this, LOGL_NOTICE,
 			"Timeslot Allocation failed: trx = %d, single_slot = %d\n",
 			use_trx, single_slot);
+		bts_do_rate_ctr_inc(bts, CTR_TBF_ALLOC_FAIL);
 		return -1;
 	}
 	/* assign control ts */

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/23106
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I0696bf77364bd31b96c00614a58ce66809683d1c
Gerrit-Change-Number: 23106
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210226/5946479c/attachment.htm>


More information about the gerrit-log mailing list