Change in docker-playground[master]: jenkins-common: put fix_perms() in clean_up_common

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

osmith gerrit-no-reply at lists.osmocom.org
Fri Feb 26 08:34:39 UTC 2021


osmith has submitted this change. ( https://gerrit.osmocom.org/c/docker-playground/+/23003 )

Change subject: jenkins-common: put fix_perms() in clean_up_common
......................................................................

jenkins-common: put fix_perms() in clean_up_common

Don't call fix_perms from collect_logs anymore, it looks like it was
only added there to avoid adding it at the end of each jenkins.sh. Now
that we have clean_up_common, put it there.

Related: OS#3208
Change-Id: I6e7e5b35198f420e130b1282eb948b96ccd6c8e0
---
M jenkins-common.sh
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  osmith: Verified
  pespin: Looks good to me, approved
  laforge: Looks good to me, but someone else must approve



diff --git a/jenkins-common.sh b/jenkins-common.sh
index 978f003..2d596d6 100644
--- a/jenkins-common.sh
+++ b/jenkins-common.sh
@@ -156,7 +156,6 @@
 }
 
 collect_logs() {
-	fix_perms
 	cat "$VOL_BASE_DIR"/*/junit-*.log || true
 }
 
@@ -180,6 +179,7 @@
 	network_clean
 	network_remove
 	rm -rf "$VOL_BASE_DIR"/unix
+	fix_perms
 	collect_logs
 }
 

-- 
To view, visit https://gerrit.osmocom.org/c/docker-playground/+/23003
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-Change-Id: I6e7e5b35198f420e130b1282eb948b96ccd6c8e0
Gerrit-Change-Number: 23003
Gerrit-PatchSet: 4
Gerrit-Owner: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210226/8462350c/attachment.htm>


More information about the gerrit-log mailing list