Change in osmo-pcu[master]: pdch: Standarize and improve logging

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

fixeria gerrit-no-reply at lists.osmocom.org
Thu Feb 25 22:18:07 UTC 2021


fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/23107 )

Change subject: pdch: Standarize and improve logging
......................................................................


Patch Set 1: Code-Review+1

(2 comments)

https://gerrit.osmocom.org/c/osmo-pcu/+/23107/1/src/pdch.h 
File src/pdch.h:

https://gerrit.osmocom.org/c/osmo-pcu/+/23107/1/src/pdch.h@199 
PS1, Line 199: 	LOGP(category, level, "PDCH(BTS=%" PRIu8 ",TRX=%" PRIu8 ",TS=%" PRIu8 ") " fmt, \
I would use lower case for 'bts'/'trx'/'ts' here for consistency with osmo-bts.


https://gerrit.osmocom.org/c/osmo-pcu/+/23107/1/src/pdch.cpp 
File src/pdch.cpp:

https://gerrit.osmocom.org/c/osmo-pcu/+/23107/1/src/pdch.cpp@691 
PS1, Line 691: 		     "but TLLI 0x%08x is unknown\n", report->TLLI);
alignment (not critical)



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/23107
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I1686a72eb9f9014ed3365376bc43d59d60bee8a5
Gerrit-Change-Number: 23107
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Comment-Date: Thu, 25 Feb 2021 22:18:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210225/d882ff63/attachment.htm>


More information about the gerrit-log mailing list