This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
laforge gerrit-no-reply at lists.osmocom.orglaforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/23014 ) Change subject: gprs_bssgp_pcu: ensure only known BVCI can be resetted by the SGSN ...................................................................... Patch Set 4: (2 comments) https://gerrit.osmocom.org/c/osmo-pcu/+/23014/4/src/gprs_bssgp_pcu.c File src/gprs_bssgp_pcu.c: https://gerrit.osmocom.org/c/osmo-pcu/+/23014/4/src/gprs_bssgp_pcu.c@460 PS4, Line 460: !TLVP_PRESENT(&tp, BSSGP_IE_BVCI) I think we do have a BSSGP parser that knows which IEs are mandatory and which are not. I'd prefer using that one rathert han adding additional checks here. See osmo_pdef_bssgp, which enforces that BVCI and CAUSE are present in any RESET. https://gerrit.osmocom.org/c/osmo-pcu/+/23014/4/src/gprs_bssgp_pcu.c@461 PS4, Line 461: an super unimportatn: I'd remove the "an" here to make it more in line with the other message below, which also doesn't state "Rx an BSSGP-RESET" -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/23014 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I04e36ce4a29e51d85e67a0d3a81aa0e1eb9e9c08 Gerrit-Change-Number: 23014 Gerrit-PatchSet: 4 Gerrit-Owner: lynxis lazus <lynxis at fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann at sysmocom.de> Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-Comment-Date: Tue, 23 Feb 2021 12:28:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210223/2de64bda/attachment.htm>