This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
fixeria gerrit-no-reply at lists.osmocom.orgfixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/23031 ) Change subject: Support uplink multi-slot allocations ...................................................................... Patch Set 2: (3 comments) Is there a reason to keep the old allocation function commented out? https://gerrit.osmocom.org/c/osmo-pcu/+/23031/2//COMMIT_MSG Commit Message: https://gerrit.osmocom.org/c/osmo-pcu/+/23031/2//COMMIT_MSG@22 PS2, Line 22: because due to 'because' looks wrong here, but not critical https://gerrit.osmocom.org/c/osmo-pcu/+/23031/2/src/gprs_rlcmac_ts_alloc.cpp File src/gprs_rlcmac_ts_alloc.cpp: https://gerrit.osmocom.org/c/osmo-pcu/+/23031/2/src/gprs_rlcmac_ts_alloc.cpp@752 PS2, Line 752: /*static int allocate_usf(const gprs_rlcmac_trx *trx, int8_t first_common_ts, uint8_t selected_ul_slots, uint8_t dl_slots, Please use #if 0 ... #endif, this is the usual approach for commenting out large blocks. https://gerrit.osmocom.org/c/osmo-pcu/+/23031/2/src/gprs_rlcmac_ts_alloc.cpp@772 PS2, Line 772: //We will stick to that single UL slot, unreserve the others ... so you will not need to do such unrelated changes. -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/23031 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Id97cc6e3b769511b591b1694549e0dac55227c43 Gerrit-Change-Number: 23031 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy at sysmocom.de> Gerrit-Comment-Date: Mon, 22 Feb 2021 18:51:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210222/e29ab1ac/attachment.htm>