Change in pysim[master]: serial: do not try to close non existing serial connection

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

dexter gerrit-no-reply at lists.osmocom.org
Mon Feb 22 15:24:21 UTC 2021


dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/23030 )


Change subject: serial: do not try to close non existing serial connection
......................................................................

serial: do not try to close non existing serial connection

The SerialSimLink only has an _sl member if serial initalization was
successfull. If we close a serial connection, check if we even have the
_sl member. Otherwise move on silently.

Change-Id: Ic3f3f5e50d780f424da7d0be5733d7167bb7159c
---
M pySim/transport/serial.py
1 file changed, 2 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/30/23030/1

diff --git a/pySim/transport/serial.py b/pySim/transport/serial.py
index 39df730..9730e3b 100644
--- a/pySim/transport/serial.py
+++ b/pySim/transport/serial.py
@@ -52,7 +52,8 @@
 		self._atr = None
 
 	def __del__(self):
-		self._sl.close()
+		if (hasattr(self, "_sl")):
+			self._sl.close()
 
 	def wait_for_card(self, timeout=None, newcardonly=False):
 		# Direct try

-- 
To view, visit https://gerrit.osmocom.org/c/pysim/+/23030
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: Ic3f3f5e50d780f424da7d0be5733d7167bb7159c
Gerrit-Change-Number: 23030
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210222/d22c7aa0/attachment.htm>


More information about the gerrit-log mailing list