Change in osmo-pcu[master]: Use ALPHA value received in SI13 from PCUIF

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

pespin gerrit-no-reply at lists.osmocom.org
Mon Feb 22 12:29:10 UTC 2021


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/22801 )

Change subject: Use ALPHA value received in SI13 from PCUIF
......................................................................


Patch Set 2: Code-Review+2

(1 comment)

https://gerrit.osmocom.org/c/osmo-pcu/+/22801/2/src/pcu_l1_if.cpp 
File src/pcu_l1_if.cpp:

https://gerrit.osmocom.org/c/osmo-pcu/+/22801/2/src/pcu_l1_if.cpp@344 
PS2, Line 344: 				LOGP(DPCU, LOGL_ERROR, "Error decoding SI13\n");
> This looks like a different logical change, put this in an own commit? […]
That's definetly related to the patch, since it's where we get the new value from.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/22801
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I46f2a955b157a409055fca7fb917dc4f75482426
Gerrit-Change-Number: 22801
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann at sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: lynxis lazus <lynxis at fe80.eu>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Mon, 22 Feb 2021 12:29:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: osmith <osmith at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210222/e0885c37/attachment.htm>


More information about the gerrit-log mailing list