Change in libosmocore[master]: gprs_bssgp: use BVCI_SIGNALLING/BVCI_PTM instead of 0/1

[lynxis lazus]

lynxis lazus has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/23013 )


Change subject: gprs_bssgp: use BVCI_SIGNALLING/BVCI_PTM instead of 0/1
......................................................................

gprs_bssgp: use BVCI_SIGNALLING/BVCI_PTM instead of 0/1

Makes more understandable and clear what's meant in the code.

Change-Id: I9d0545fac0af0dcc1783040a376a9b8e65a92699
---
M src/gb/gprs_bssgp.c
1 file changed, 2 insertions(+), 2 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/13/23013/1

diff --git a/src/gb/gprs_bssgp.c b/src/gb/gprs_bssgp.c
index 5c71699..abe5fb4 100644
--- a/src/gb/gprs_bssgp.c
+++ b/src/gb/gprs_bssgp.c
@@ -380,7 +380,7 @@
 
 	/* When we receive a BVC-RESET PDU (at least of a PTP BVCI), the BSS
 	 * informs us about its RAC + Cell ID, so we can create a mapping */
-	if (bctx->is_sgsn && bvci != 0 && bvci != 1) {
+	if (bctx->is_sgsn && bvci != BVCI_SIGNALLING && bvci != BVCI_PTM) {
 		if (!TLVP_PRES_LEN(tp, BSSGP_IE_CELL_ID, 8)) {
 			LOGP(DLBSSGP, LOGL_ERROR, "BSSGP BVCI=%u Rx RESET "
 				"missing mandatory IE\n", bvci);
@@ -394,7 +394,7 @@
 	}
 
 	/* Acknowledge the RESET to the BTS */
-	if (bvci == 0 || bvci == 1 || bctx->is_sgsn)
+	if (bvci == BVCI_SIGNALLING || bvci == BVCI_PTM || bctx->is_sgsn)
 		bssgp_tx_simple_bvci(BSSGP_PDUT_BVC_RESET_ACK,
 				     nsei, bvci, ns_bvci);
 	else

-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/23013
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I9d0545fac0af0dcc1783040a376a9b8e65a92699
Gerrit-Change-Number: 23013
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus <lynxis at fe80.eu>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210222/96b1f254/attachment.htm>