Change in osmo-ggsn[master]: gtp-kernel: don't #include libmnl headers

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Sat Feb 20 10:06:31 UTC 2021


laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/23008 )


Change subject: gtp-kernel: don't #include libmnl headers
......................................................................

gtp-kernel: don't #include libmnl headers

* we don't check for libmnl via pkg-config in configure.ac
* we don't add libmnl include path to CFLAGS

As a result, we cannot #include related files.  All we really need
is a forward-declaration of 'struct mnl_socket' to which we then
add a pointer.

Change-Id: I0af869cc3c8e30b69d73a4985c56ef7743565e95
---
M contrib/osmo-ggsn.spec.in
M lib/gtp-kernel.c
2 files changed, 2 insertions(+), 2 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-ggsn refs/changes/08/23008/1

diff --git a/contrib/osmo-ggsn.spec.in b/contrib/osmo-ggsn.spec.in
index 83a1ca7..d752a8e 100644
--- a/contrib/osmo-ggsn.spec.in
+++ b/contrib/osmo-ggsn.spec.in
@@ -30,7 +30,6 @@
 BuildRequires:  systemd-rpm-macros
 %endif
 BuildRequires:  pkgconfig(libgtpnl) >= 1.0.0
-BuildRequires:  pkgconfig(libmnl) >= 1.0.3
 BuildRequires:  pkgconfig(libosmocore) >= 1.1.0
 BuildRequires:  pkgconfig(libosmoctrl) >= 1.1.0
 BuildRequires:  pkgconfig(libosmovty) >= 1.1.0
diff --git a/lib/gtp-kernel.c b/lib/gtp-kernel.c
index b898ed7..7cd19ad 100644
--- a/lib/gtp-kernel.c
+++ b/lib/gtp-kernel.c
@@ -18,7 +18,6 @@
 
 #include <libgtpnl/gtp.h>
 #include <libgtpnl/gtpnl.h>
-#include <libmnl/libmnl.h>
 
 #include <errno.h>
 
@@ -54,6 +53,8 @@
 		buf4, buf6, inet_ntoa(ia));
 }
 
+struct mnl_socket;
+
 static struct {
 	int			genl_id;
 	struct mnl_socket	*nl;

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/23008
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ggsn
Gerrit-Branch: master
Gerrit-Change-Id: I0af869cc3c8e30b69d73a4985c56ef7743565e95
Gerrit-Change-Number: 23008
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge at osmocom.org>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210220/457cc458/attachment.htm>


More information about the gerrit-log mailing list