Change in osmo-pcu[master]: gprs_bssgp: use gprs_ns2_sns_add_bind() to allow the NSE to use the b...

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

lynxis lazus gerrit-no-reply at lists.osmocom.org
Fri Feb 19 12:00:47 UTC 2021


lynxis lazus has submitted this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/22914 )

Change subject: gprs_bssgp: use gprs_ns2_sns_add_bind() to allow the NSE to use the binds for IP-SNS configuration
......................................................................

gprs_bssgp: use gprs_ns2_sns_add_bind() to allow the NSE to use the binds for IP-SNS configuration

The gprs_ns2 now requires to specify every bind which should be used by the NSE for IP-SNS

Related: SYS#5354
Depends: I9ab8092bf286e7d90e92f5702a5404425e959c84 (libosmocore)
Change-Id: I35c987224ce098f7ee9f189ce0fce9e68ad3feac
---
M src/gprs_bssgp_pcu.c
1 file changed, 8 insertions(+), 0 deletions(-)

Approvals:
  laforge: Looks good to me, approved
  pespin: Looks good to me, but someone else must approve
  Jenkins Builder: Verified



diff --git a/src/gprs_bssgp_pcu.c b/src/gprs_bssgp_pcu.c
index ce36c6b..84e9ec5 100644
--- a/src/gprs_bssgp_pcu.c
+++ b/src/gprs_bssgp_pcu.c
@@ -1023,6 +1023,14 @@
 				LOGP(DBSSGP, LOGL_ERROR, "Failed to bind to %s\n", osmo_sockaddr_to_str(&local[i]));
 				continue;
 			}
+
+			if (the_pcu->vty.ns_dialect == GPRS_NS2_DIALECT_SNS) {
+				rc = gprs_ns2_sns_add_bind(bts->nse, bind[i]);
+				if (rc < 0) {
+					LOGP(DBSSGP, LOGL_ERROR, "Failed to add bind %s to the NSE for IP-SNS\n", osmo_sockaddr_to_str(&local[i]));
+					continue;
+				}
+			}
 		}
 
 		binds |= 1 << i;

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/22914
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I35c987224ce098f7ee9f189ce0fce9e68ad3feac
Gerrit-Change-Number: 22914
Gerrit-PatchSet: 4
Gerrit-Owner: lynxis lazus <lynxis at fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: lynxis lazus <lynxis at fe80.eu>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210219/efb0ef20/attachment.htm>


More information about the gerrit-log mailing list