Change in osmo-pcu[master]: Use ALPHA value received in SI13 from PCUIF

[fixeria]

fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/22801 )

Change subject: Use ALPHA value received in SI13 from PCUIF
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.osmocom.org/c/osmo-pcu/+/22801/1/src/pcu_vty.c 
File src/pcu_vty.c:

https://gerrit.osmocom.org/c/osmo-pcu/+/22801/1/src/pcu_vty.c@746 
PS1, Line 746: 		the_pcu->vty.force_alpha = atoi(argv[0]);
The problem is that these warnings are being printed in the beginning of the log without a prefix with category and logging level. And if you manage the services using systemd, it's unlikely that you check journald every time after updating the packages. If only we had some permanent buffer, from where one could retrieve all the warnings e.g. via the VTY ('show vty-depr-warnings' or so)...

> ... instead of explaining him how can he still be using this.

I am not asking you to explain how to use deprecated parameters. I am asking to warn the user about consequences of not using the new ones. It's not obvious what takes preference without looking into the code. And it's actually quite often that I see deprecated parameters in use, even in our testing infrastructure (docker-playground).



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/22801
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I46f2a955b157a409055fca7fb917dc4f75482426
Gerrit-Change-Number: 22801
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-CC: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Comment-Date: Thu, 18 Feb 2021 18:36:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Comment-In-Reply-To: fixeria <vyanitskiy at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210218/4895f0ed/attachment.htm>