Change in osmo-bsc[master]: Set FSM pointer to NULL when changing BTS Type

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

keith gerrit-no-reply at lists.osmocom.org
Thu Feb 18 01:19:19 UTC 2021


keith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/22954 )

Change subject: Set FSM pointer to NULL when changing BTS Type
......................................................................


Patch Set 3:

> Patch Set 3:
> 
> I don't really think that this was ever suppored (changing the BTS model at runtime).  Setting the field to NULL may be leaking memory, not sure if that's all the better...

OK. My skills on memory leakage being akin to my skill for leaking euros in a bar... I'm not sure what to do, but will try something else. - in gdb by the way, before I set it to null it was set to something unreachable. Config had type sysmobts on startup.

I get that one shouldn't be changing BTS type at runtime, but we really don't want a running osmo-bsc to CRASH because the operator typed something in the vty, right? 

One might actually bring it up with a blank or default config and then try to configure via the vty.


-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/22954
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I634fe52d598253454a50cb782d93ada83e6d88d1
Gerrit-Change-Number: 22954
Gerrit-PatchSet: 3
Gerrit-Owner: keith <keith at rhizomatica.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Comment-Date: Thu, 18 Feb 2021 01:19:19 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210218/448972b0/attachment.htm>


More information about the gerrit-log mailing list