Change in osmo-bsc[master]: Set FSM pointer to NULL when changing BTS Type

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

keith gerrit-no-reply at lists.osmocom.org
Thu Feb 18 00:33:54 UTC 2021


keith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/22954 )


Change subject: Set FSM pointer to NULL when changing BTS Type
......................................................................

Set FSM pointer to NULL when changing BTS Type

There is an OSMO_ASSERT check for !bts->rbs2000.bts_fi in om2k_bts_fsm_alloc()
so (re)set the pointer to NULL when changing BTS type from the vty, before
calling the FSM Allocate.

Change-Id: I634fe52d598253454a50cb782d93ada83e6d88d1
---
M src/osmo-bsc/bts.c
1 file changed, 3 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/54/22954/1

diff --git a/src/osmo-bsc/bts.c b/src/osmo-bsc/bts.c
index 548d724..dc897f0 100644
--- a/src/osmo-bsc/bts.c
+++ b/src/osmo-bsc/bts.c
@@ -507,6 +507,9 @@
 		model->started = true;
 	}
 
+	if (bts->type == GSM_BTS_TYPE_RBS2000)
+		bts->rbs2000.bts_fi = NULL;
+
 	if (model->bts_init) {
 		int rc = model->bts_init(bts);
 		if (rc < 0)

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/22954
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I634fe52d598253454a50cb782d93ada83e6d88d1
Gerrit-Change-Number: 22954
Gerrit-PatchSet: 1
Gerrit-Owner: keith <keith at rhizomatica.org>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210218/9ee2503f/attachment.htm>


More information about the gerrit-log mailing list