This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
iedemam gerrit-no-reply at lists.osmocom.orgiedemam has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/22947 ) Change subject: stats: add SIGN/SPEECH assignment subcategories ...................................................................... Patch Set 2: (1 comment) Hi, Thanks for the review. Let me know if it's clearer (and worth it) to refactor underlying macros. -Michael https://gerrit.osmocom.org/c/osmo-bsc/+/22947/2/src/osmo-bsc/assignment_fsm.c File src/osmo-bsc/assignment_fsm.c: https://gerrit.osmocom.org/c/osmo-bsc/+/22947/2/src/osmo-bsc/assignment_fsm.c@102 PS2, Line 102: #define assignment_count_result(counter) do { \ > did you think about extending this one with a "chan_mode" param and do the rate_ctr_inc only once he […] If that's preferable, I can rework the underlying macros as I had to do for ASSIGNMENT_ERROR. I wanted to leave as much alone as possible. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/22947 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I73f4dab6edb0951180f2bbcfc352ff34de647679 Gerrit-Change-Number: 22947 Gerrit-PatchSet: 2 Gerrit-Owner: iedemam <michael at kapsulate.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-Comment-Date: Wed, 17 Feb 2021 13:03:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin at sysmocom.de> Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210217/62bda5d0/attachment.htm>