This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
daniel gerrit-no-reply at lists.osmocom.orgdaniel has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/22872 ) Change subject: gprs_ns2: rework IP-SNS binds ...................................................................... Patch Set 10: Code-Review-1 (2 comments) https://gerrit.osmocom.org/c/libosmocore/+/22872/10/src/gb/gprs_ns2_vty.c File src/gb/gprs_ns2_vty.c: https://gerrit.osmocom.org/c/libosmocore/+/22872/10/src/gb/gprs_ns2_vty.c@182 PS10, Line 182: talloc_free(vnse); Remove all vnse->binds or at least add a comment that talloc is expected to do this for us here. https://gerrit.osmocom.org/c/libosmocore/+/22872/10/src/gb/gprs_ns2_vty.c@202 PS10, Line 202: vnse Shouldn't this be vnse_bind->list ? -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/22872 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I9ab8092bf286e7d90e92f5702a5404425e959c84 Gerrit-Change-Number: 22872 Gerrit-PatchSet: 10 Gerrit-Owner: lynxis lazus <lynxis at fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann at sysmocom.de> Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-Comment-Date: Tue, 16 Feb 2021 16:29:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210216/4066bcf1/attachment.htm>