Change in osmo-gbproxy[master]: Add SDU length for an NSE (== BSSGP PDU size)

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

daniel gerrit-no-reply at lists.osmocom.org
Tue Feb 16 15:59:18 UTC 2021


daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gbproxy/+/22877 )

Change subject: Add SDU length for an NSE (== BSSGP PDU size)
......................................................................


Patch Set 4:

(1 comment)

https://gerrit.osmocom.org/c/osmo-gbproxy/+/22877/3/include/osmocom/sgsn/gb_proxy.h 
File include/osmocom/sgsn/gb_proxy.h:

https://gerrit.osmocom.org/c/osmo-gbproxy/+/22877/3/include/osmocom/sgsn/gb_proxy.h@24 
PS3, Line 24: MTU
> Done
On second thought I don't really like the whole MTU -> SDU renaming..
MTU is relative to the current layer the *Maximum* transfer unit so the name MTU makes sense.
PDU/SDU has the issue that the don't actually refer to the maximum size so to be correct we would need something like max_sdu max_pdu.

On the other hand I have almost had enough bike-shedding over this issue.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-gbproxy/+/22877
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gbproxy
Gerrit-Branch: master
Gerrit-Change-Id: Ic1080abde942ec5a2ae7cdee0ffe716a2fbddb1e
Gerrit-Change-Number: 22877
Gerrit-PatchSet: 4
Gerrit-Owner: daniel <dwillmann at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: lynxis lazus <lynxis at fe80.eu>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Tue, 16 Feb 2021 15:59:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge at osmocom.org>
Comment-In-Reply-To: daniel <dwillmann at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210216/22561e71/attachment.htm>


More information about the gerrit-log mailing list