Change in libosmocore[master]: gprs_ns2: inform the NS user (BSSGP) about the MTU of a NSE

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

lynxis lazus gerrit-no-reply at lists.osmocom.org
Tue Feb 16 14:49:21 UTC 2021


lynxis lazus has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/22343 )

Change subject: gprs_ns2: inform the NS user (BSSGP) about the MTU of a NSE
......................................................................


Patch Set 11:

(4 comments)

https://gerrit.osmocom.org/c/libosmocore/+/22343/11/include/osmocom/gprs/frame_relay.h 
File include/osmocom/gprs/frame_relay.h:

https://gerrit.osmocom.org/c/libosmocore/+/22343/11/include/osmocom/gprs/frame_relay.h@45 
PS11, Line 45: #define FRAME_RELAY_SDU FRAME_RELAY_MTU - 2
> Ack
Done


https://gerrit.osmocom.org/c/libosmocore/+/22343/11/src/gb/gprs_ns2.c 
File src/gb/gprs_ns2.c:

https://gerrit.osmocom.org/c/libosmocore/+/22343/11/src/gb/gprs_ns2.c@a468 
PS11, Line 468: 
> non related
Done


https://gerrit.osmocom.org/c/libosmocore/+/22343/11/src/gb/gprs_ns2.c@501 
PS11, Line 501: 		nsp.u.status.mtu = nse->mtu - 4; /* 1b NS PDU type, 1b NS SDU control, 2b BVCI */
> Ack, we should have a ns_unitdata_hdr struct.
I agree.But can this in a different commit?


https://gerrit.osmocom.org/c/libosmocore/+/22343/11/src/gb/gprs_ns2_udp.c 
File src/gb/gprs_ns2_udp.c:

https://gerrit.osmocom.org/c/libosmocore/+/22343/11/src/gb/gprs_ns2_udp.c@a116 
PS11, Line 116: 
> Ack
Done



-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/22343
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I5016b295db6185ec131d83089cf6c806e34ef1b6
Gerrit-Change-Number: 22343
Gerrit-PatchSet: 11
Gerrit-Owner: lynxis lazus <lynxis at fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Tue, 16 Feb 2021 14:49:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge at osmocom.org>
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210216/d2e5d7e4/attachment.htm>


More information about the gerrit-log mailing list