Change in osmo-pcu[master]: gprs_bssgp: rework ns_create_nsvc

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

pespin gerrit-no-reply at lists.osmocom.org
Mon Feb 15 10:14:45 UTC 2021


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/22913 )

Change subject: gprs_bssgp: rework ns_create_nsvc
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/c/osmo-pcu/+/22913/1/src/gprs_bssgp_pcu.c 
File src/gprs_bssgp_pcu.c:

https://gerrit.osmocom.org/c/osmo-pcu/+/22913/1/src/gprs_bssgp_pcu.c@1049 
PS1, Line 1049: 		return sns_configured ? 0 : 1;
returning 1 here? are you sure this is OK? Please write documentation for this function.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/22913
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I69cf48ab168a6dca4f649157bf6556d7cd27d4fb
Gerrit-Change-Number: 22913
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus <lynxis at fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Mon, 15 Feb 2021 10:14:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210215/b52a74a2/attachment.htm>


More information about the gerrit-log mailing list