Change in docker-playground[master]: Revert "RFC: allow to set configuration and/or specific testcases"

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

osmith gerrit-no-reply at lists.osmocom.org
Mon Feb 15 07:09:32 UTC 2021


osmith has submitted this change. ( https://gerrit.osmocom.org/c/docker-playground/+/22882 )

Change subject: Revert "RFC: allow to set configuration and/or specific testcases"
......................................................................

Revert "RFC: allow to set configuration and/or specific testcases"

Fix error message reported by Pau:
  docker: invalid reference format: repository name must be lowercase.

This happens in the "docker run" command after the "Starting container
to merge logs" message, because the arguments to --entrypoint are not in
quotation marks. The command fails.

Logs were merged anyway, because
If03422bb8fb126fe6f204a4f8bc6edf0cbb7f194 had already reverted half the
patch and added the log merging back to the Dockerfile.

This reverts commit 73663b01f21e9a01cf3e5048d802270c482852cf.

Change-Id: Ie6f8270230e1f0372b63d610b7868ea8719b18ad
---
M ttcn3-sgsn-test/jenkins.sh
1 file changed, 0 insertions(+), 11 deletions(-)

Approvals:
  laforge: Looks good to me, but someone else must approve
  pespin: Looks good to me, but someone else must approve
  osmith: Looks good to me, approved; Verified



diff --git a/ttcn3-sgsn-test/jenkins.sh b/ttcn3-sgsn-test/jenkins.sh
index 623f468..35eaf2e 100755
--- a/ttcn3-sgsn-test/jenkins.sh
+++ b/ttcn3-sgsn-test/jenkins.sh
@@ -56,17 +56,6 @@
 		-v $VOL_BASE_DIR/sgsn-tester:/data \
 		--name ${BUILD_TAG}-ttcn3-sgsn-test \
 		$DOCKER_ARGS \
-		$REPO_USER/ttcn3-sgsn-test $@
-
-echo Starting container to merge logs
-docker run	--rm \
-		$(docker_network_params $SUBNET 103) \
-		--ulimit core=-1 \
-		-e "TTCN3_PCAP_PATH=/data" \
-		-v $VOL_BASE_DIR/sgsn-tester:/data \
-		--name ${BUILD_TAG}-ttcn3-sgsn-test-logmerge \
-		--entrypoint /osmo-ttcn3-hacks/log_merge.sh SGSN_Tests --rm \
-		$DOCKER_ARGS \
 		$REPO_USER/ttcn3-sgsn-test
 
 echo Stopping containers

-- 
To view, visit https://gerrit.osmocom.org/c/docker-playground/+/22882
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-Change-Id: Ie6f8270230e1f0372b63d610b7868ea8719b18ad
Gerrit-Change-Number: 22882
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210215/3d1105b8/attachment.htm>


More information about the gerrit-log mailing list