Change in osmo-bts[master]: l1sap: be sure that the DL-SACCH l1 header is also repeated

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

fixeria gerrit-no-reply at lists.osmocom.org
Fri Feb 12 23:39:53 UTC 2021


fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/22887 )

Change subject: l1sap: be sure that the DL-SACCH l1 header is also repeated
......................................................................


Patch Set 1:

> Patch Set 1:
> 
> Are you sure the lower layers will not override the L1 SACCH header? I am afraid they (most likely) will.

Nevermind. This only applies to DSP based models and when DSP based power control is enabled. The L1 SACCH header is composed in l1sap.c regardless of the model, and may be overwritten by DSP based models. Since they do not support ACCH repetition, this is not a problem.


-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/22887
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I6ae601c84dd0df0c9ae142c3295da36f3222b0c9
Gerrit-Change-Number: 22887
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Comment-Date: Fri, 12 Feb 2021 23:39:53 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210212/a234b657/attachment.htm>


More information about the gerrit-log mailing list