This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
fixeria gerrit-no-reply at lists.osmocom.orgfixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/22888 )
Change subject: l1sap: add logging for ACCH repetition
......................................................................
Patch Set 1:
(9 comments)
IMHO, this amount of logging is only suitable for development stage. For a regular user/customer trying to understand what's going on it's too verbose.
https://gerrit.osmocom.org/c/osmo-bts/+/22888/1/src/common/l1sap.c
File src/common/l1sap.c:
https://gerrit.osmocom.org/c/osmo-bts/+/22888/1/src/common/l1sap.c@938
PS1, Line 938: DL1C
Pau was complaining about unreadable DL1C (https://osmocom.org/issues/5007), maybe DL1P?
The 'L1C' stands for "Layer 1 Control", 'DL1P' stands for "Layer 1 Primitives".
https://gerrit.osmocom.org/c/osmo-bts/+/22888/1/src/common/l1sap.c@938
PS1, Line 938: DL-FACCH repetition: repeating FACCH channel
How can you 'repeat FACCH channel'? You actually repeat a 'FACCH block', or more precisely 'retransmit' it.
https://gerrit.osmocom.org/c/osmo-bts/+/22888/1/src/common/l1sap.c@943
PS1, Line 943: channel
Same here.
https://gerrit.osmocom.org/c/osmo-bts/+/22888/1/src/common/l1sap.c@994
PS1, Line 994: LOGPLCHAN(lchan, DL1C, LOGL_DEBUG, "DL-FACCH repetition: disabled by BSC\n");
This looks redundant to me, if it's disabled that I would not expect any logging.
https://gerrit.osmocom.org/c/osmo-bts/+/22888/1/src/common/l1sap.c@1044
PS1, Line 1044: if (rxqual >= upper) {
How about storing the current 'repeated_dl_facch_active' value and logging only if it changes from true to false and vice versa?
https://gerrit.osmocom.org/c/osmo-bts/+/22888/1/src/common/l1sap.c@1066
PS1, Line 1066: LOGPLCHAN(lchan, DL1C, LOGL_DEBUG, "DL-SACCH repetition: MS does not request DL-SACCH repetition (SRR=0)\n");
This also looks redundant, and would probably make 'DL1C' unreadable.
https://gerrit.osmocom.org/c/osmo-bts/+/22888/1/src/common/l1sap.c@1083
PS1, Line 1083: channel
block
https://gerrit.osmocom.org/c/osmo-bts/+/22888/1/src/common/l1sap.c@1091
PS1, Line 1091:
ws, unrelated
https://gerrit.osmocom.org/c/osmo-bts/+/22888/1/src/common/l1sap.c@1468
PS1, Line 1468: LOGPLCHAN(lchan, DL1C, LOGL_DEBUG, "UL-SACCH repetition: disabled by BSC\n");
Same here.
--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/22888
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I59d11fd03be3d29fb8a4279d9945b03006764c0e
Gerrit-Change-Number: 22888
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-CC: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Comment-Date: Fri, 12 Feb 2021 22:39:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210212/99a694c9/attachment.htm>