Change in osmo-ttcn3-hacks[master]: pcu: Introduce several tests TC_nacc_outbound_pkt_cell_chg_notif_dup*

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

daniel gerrit-no-reply at lists.osmocom.org
Fri Feb 12 15:38:40 UTC 2021


daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22857 )

Change subject: pcu: Introduce several tests TC_nacc_outbound_pkt_cell_chg_notif_dup*
......................................................................


Patch Set 2: -Code-Review

(1 comment)

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22857/1/pcu/PCU_Tests.ttcn 
File pcu/PCU_Tests.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22857/1/pcu/PCU_Tests.ttcn@4285 
PS1, Line 4285: 	cell_chf_notif := ts_RlcMacUlCtrl_PKT_CELL_CHG_NOTIF(ms.ul_tbf.tfi, req_arfcn, req_bsic);
> I already thought about it but in general most of the stuf above is already test specific stuff like […]
Well, ok, but from a review perspective as someone who dislikes reading TTCN3 and is not really familiar with NACC reading these lines over and over and figuring out what if any is the difference and if it makes sense or not is quite straining.

Could be just me an my (love-) hate relationship with ttcn3, though. :-)



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22857
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ib83eacfab7a73a2a51ab08801ff1c00c0058057c
Gerrit-Change-Number: 22857
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann at sysmocom.de>
Gerrit-Comment-Date: Fri, 12 Feb 2021 15:38:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Comment-In-Reply-To: daniel <dwillmann at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210212/9c31fcd0/attachment.htm>


More information about the gerrit-log mailing list