Change in libosmocore[master]: bssgp_bvc_fsm: Add MTU support

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Fri Feb 12 09:06:23 UTC 2021


laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/22873 )

Change subject: bssgp_bvc_fsm: Add MTU support
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/c/libosmocore/+/22873/1//COMMIT_MSG 
Commit Message:

https://gerrit.osmocom.org/c/libosmocore/+/22873/1//COMMIT_MSG@5 
PS1, Line 5: CommitDate: 2021-02-12 03:33:30 +0100
I think we should somehow specify what it means specifically.  Does this track the maximum BSSGP payload size, or does it include the NS header?

I would think it makes sense for the BSSGP layer to direclty only care with the size of its own messages, and not have to know how much overhead NS or any other layers below add.

So maye consider renaming it to something != MTU (as that always has that "ethernet" notion of being the physical transport size MTU) and have something like max_bssgp_size or the like.

In any case, ther are many options. The importance of my message is that the code should contain a clear definition (in comment / api doc / ...) what exact size including/excluding which headers at what layer is specified.



-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/22873
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I9bb82ead27366b7370c9ff968e03ca2113ec11f0
Gerrit-Change-Number: 22873
Gerrit-PatchSet: 1
Gerrit-Owner: daniel <dwillmann at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: lynxis lazus <lynxis at fe80.eu>
Gerrit-CC: laforge <laforge at osmocom.org>
Gerrit-Comment-Date: Fri, 12 Feb 2021 09:06:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210212/2b8e45ea/attachment.htm>


More information about the gerrit-log mailing list