Change in libosmocore[master]: gprs_ns2: add signalling & data weights for UDP binds

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

lynxis lazus gerrit-no-reply at lists.osmocom.org
Fri Feb 12 02:35:18 UTC 2021


lynxis lazus has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/22868 )

Change subject: gprs_ns2: add signalling & data weights for UDP binds
......................................................................


Patch Set 3:

(8 comments)

https://gerrit.osmocom.org/c/libosmocore/+/22868/1//COMMIT_MSG 
Commit Message:

https://gerrit.osmocom.org/c/libosmocore/+/22868/1//COMMIT_MSG@9 
PS1, Line 9: date
> data
Done


https://gerrit.osmocom.org/c/libosmocore/+/22868/1//COMMIT_MSG@10 
PS1, Line 10:  use 
> used
Done


https://gerrit.osmocom.org/c/libosmocore/+/22868/1//COMMIT_MSG@12 
PS1, Line 12: use
> uses
Done


https://gerrit.osmocom.org/c/libosmocore/+/22868/1//COMMIT_MSG@15 
PS1, Line 15: support
> supports
Done


https://gerrit.osmocom.org/c/libosmocore/+/22868/1/include/osmocom/gprs/gprs_ns2.h 
File include/osmocom/gprs/gprs_ns2.h:

https://gerrit.osmocom.org/c/libosmocore/+/22868/1/include/osmocom/gprs/gprs_ns2.h@218 
PS1, Line 218: void gprs_ns2_ip_bind_set_sns_weight(struct gprs_ns2_vc_bind *bind,
> Also add it in libosmogb. […]
Done


https://gerrit.osmocom.org/c/libosmocore/+/22868/1/src/gb/gprs_ns2_internal.h 
File src/gb/gprs_ns2_internal.h:

https://gerrit.osmocom.org/c/libosmocore/+/22868/1/src/gb/gprs_ns2_internal.h@261 
PS1, Line 261: 	uint8_t sns_signalling_weight;
> could be sns_sig_weight to stay consistent with the other variable names (ipx_elems->sig_weight)
Done


https://gerrit.osmocom.org/c/libosmocore/+/22868/1/src/gb/gprs_ns2_vty.c 
File src/gb/gprs_ns2_vty.c:

https://gerrit.osmocom.org/c/libosmocore/+/22868/1/src/gb/gprs_ns2_vty.c@69 
PS1, Line 69: 	uint8_t ip_sns_signalling_weight;
> *_sig_weight
Done


https://gerrit.osmocom.org/c/libosmocore/+/22868/1/src/gb/gprs_ns2_vty.c@335 
PS1, Line 335: 		vty_out(vty, "   ip-sns signalling-weight %u data-weight %u%s",
> sig-weight here as well? For the vty commands I'm not so sure.
I would leave it as signalling weight. Maybe @laforge has a different opinion?



-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/22868
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I5133e4229377d44772a9af28628a2bc420fea34b
Gerrit-Change-Number: 22868
Gerrit-PatchSet: 3
Gerrit-Owner: lynxis lazus <lynxis at fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann at sysmocom.de>
Gerrit-Comment-Date: Fri, 12 Feb 2021 02:35:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: daniel <dwillmann at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210212/b072c480/attachment.htm>


More information about the gerrit-log mailing list