Change in osmo-ttcn3-hacks[master]: gbproxy: Fix TC_dl_unitdata test failure introduced by 6ee0126971

[daniel]

daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22845 )

Change subject: gbproxy: Fix TC_dl_unitdata test failure introduced by 6ee0126971
......................................................................


Patch Set 1:

(2 comments)

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22845/1//COMMIT_MSG 
Commit Message:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22845/1//COMMIT_MSG@13 
PS1, Line 13: 
> Fixes: <commit hash>
Done


https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22845/1/library/Osmocom_Gb_Types.ttcn 
File library/Osmocom_Gb_Types.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22845/1/library/Osmocom_Gb_Types.ttcn@1026 
PS1, Line 1026: template IMSI_BSSGP tr_BSSGP_IMSI(template hexstring imsi) := {
> why that change?  The template does not return a * type wild card, so it is by definition always 'pr […]
I tried various things, including making the function in line 1050 non-private but that didn't compile.
tbh I don't really understand the templating restrictions in ttcn3 and how they interact so I reverted the parts of the original commit until it compiled and passed again.

But you're right, the change below on its own seems to fix the issue and after reading Ch. 15.8 of the ttcn3 core language it sort of makes sense why: omit only allows either a concrete value or omit, but not a template that matches on  '?'.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22845
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I85676e96f8d32a9d2c7deadc1d66707b6b8697d0
Gerrit-Change-Number: 22845
Gerrit-PatchSet: 1
Gerrit-Owner: daniel <dwillmann at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Thu, 11 Feb 2021 14:17:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge at osmocom.org>
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210211/d5739dd5/attachment.htm>