This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
laforge gerrit-no-reply at lists.osmocom.orglaforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/22813 ) Change subject: Move bts_ident_key to bts.c ...................................................................... Patch Set 1: Code-Review-1 > Patch Set 1: > > So, what I meant is: In the end, to me it doesn't make sense to decide to put code in the incorrect file just because then on our build foo adding lots of *.o we have to put more churn (which should be fixed as expressed in my prev comment). but it does make sense to move the function, despite it causing really ugly fall-out like long makefile dependency lists _and_ lots of stubs to be created? Sorry, I would prefere to keep it either as-is or to fix it properly. The required stubs should always be as small as possible at all. If it grows to that kind of size, we have a serious problem with encapsulation. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/22813 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Icae8b9045e497f850f22cb3b6f93acbf61b84746 Gerrit-Change-Number: 22813 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-Comment-Date: Thu, 11 Feb 2021 12:04:28 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210211/8e267252/attachment.htm>