Change in osmo-ttcn3-hacks[master]: SCCP_Templates: Make tr_SCCP_UDT work for unspecific templates

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Thu Feb 11 11:59:49 UTC 2021


laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22830 )

Change subject: SCCP_Templates: Make tr_SCCP_UDT work for unspecific templates
......................................................................


Patch Set 1:

> Can you explain better? I don't see why Length shouldn't be lengthof(data)

well, it's a receive template.  so it could be that "data == ?", i.e an unspecific template.  You cannot build lengthof() on that.

Matching the length byte has no benefit (and we generally never do), as we match the actual data.  IF the length of the data octetstring differs, you get exactly the same result.


-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22830
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ic77f52f7ec6dc8e17d9cd0789ba790296a25bc50
Gerrit-Change-Number: 22830
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge at osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Thu, 11 Feb 2021 11:59:49 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210211/abc3b1b7/attachment.htm>


More information about the gerrit-log mailing list