Change in libosmocore[master]: gsm: Introduce API osmo_gsm48_rest_octets_si13_decode

[fixeria]

fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/22800 )

Change subject: gsm: Introduce API osmo_gsm48_rest_octets_si13_decode
......................................................................


Patch Set 2: Code-Review+1

(3 comments)

https://gerrit.osmocom.org/c/libosmocore/+/22800/2/src/gsm/gsm48_rest_octets.c 
File src/gsm/gsm48_rest_octets.c:

https://gerrit.osmocom.org/c/libosmocore/+/22800/2/src/gsm/gsm48_rest_octets.c@757 
PS2, Line 757: 	static unsigned int decode_t3192_tbl[8] = {500, 1000, 1500, 0, 80, 120, 160, 200};
const


https://gerrit.osmocom.org/c/libosmocore/+/22800/2/src/gsm/gsm48_rest_octets.c@764 
PS2, Line 764: 	static unsigned int decode_drx_timer_tbl[8] = {0, 1, 2, 4, 8, 16, 32, 64};
const


https://gerrit.osmocom.org/c/libosmocore/+/22800/2/src/gsm/gsm48_rest_octets.c@789 
PS2, Line 789: bitvec_get_uint
I would be careful here, as this function may return a negative in case of error. It's not critical for most of the information fields, but length fields are special. We may end up past the buffer boundaries of something goes wrong.



-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/22800
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I74fb0a3afc1ac4aadbfc609b882d929401f790eb
Gerrit-Change-Number: 22800
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Comment-Date: Thu, 11 Feb 2021 00:17:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210211/0d9cf39a/attachment.htm>