Change in libosmocore[master]: gprs_ns2_vty: fix memory leak of vty_binds

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

daniel gerrit-no-reply at lists.osmocom.org
Tue Feb 9 16:37:39 UTC 2021


daniel has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/22796 )

Change subject: gprs_ns2_vty: fix memory leak of vty_binds
......................................................................

gprs_ns2_vty: fix memory leak of vty_binds

They never got freed, only removed from the vty_bind queue.

Change-Id: I100897c32dc152f9acbb322782fae49b1f0bc030
---
M src/gb/gprs_ns2_vty.c
1 file changed, 1 insertion(+), 0 deletions(-)

Approvals:
  Jenkins Builder: Verified
  pespin: Looks good to me, but someone else must approve
  daniel: Looks good to me, approved



diff --git a/src/gb/gprs_ns2_vty.c b/src/gb/gprs_ns2_vty.c
index 978c73b..3646080 100644
--- a/src/gb/gprs_ns2_vty.c
+++ b/src/gb/gprs_ns2_vty.c
@@ -128,6 +128,7 @@
 		return;
 
 	llist_del(&vbind->list);
+	talloc_free(vbind);
 }
 
 static struct cmd_node ns_node = {

-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/22796
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I100897c32dc152f9acbb322782fae49b1f0bc030
Gerrit-Change-Number: 22796
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus <lynxis at fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210209/7eb3a538/attachment.htm>


More information about the gerrit-log mailing list