Change in osmo-ttcn3-hacks[master]: VTY: Fix warning: control reaches end of non-void function

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Mon Feb 8 20:16:34 UTC 2021


laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22737 )

Change subject: VTY: Fix warning: control reaches end of non-void function
......................................................................

VTY: Fix warning: control reaches end of non-void function

Change-Id: Ie9415afecbcaf12e210fd4f481fcbb1f5ba52c77
---
M library/Osmocom_VTY_Functions.ttcn
1 file changed, 6 insertions(+), 3 deletions(-)

Approvals:
  Jenkins Builder: Verified
  laforge: Looks good to me, approved



diff --git a/library/Osmocom_VTY_Functions.ttcn b/library/Osmocom_VTY_Functions.ttcn
index 9410c9e..49f587d 100644
--- a/library/Osmocom_VTY_Functions.ttcn
+++ b/library/Osmocom_VTY_Functions.ttcn
@@ -10,6 +10,8 @@
  */
 
 module Osmocom_VTY_Functions {
+
+	import from Misc_Helpers all;
 	import from TELNETasp_PortType all;
 	import from Osmocom_Types all;
 
@@ -218,9 +220,10 @@
 		num_attempts := num_attempts - 1;
 	}
 
-	setverdict(fail, "No matching VTY response for regular expression '", regex,
-		   "' after ", num_attempts, " attempts." );
-	mtc.stop;
+	Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail,
+				log2str("No matching VTY response for regular expression '",
+					regex, "' after ", num_attempts, " attempts." ));
+	return "";
 }
 
 }

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22737
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ie9415afecbcaf12e210fd4f481fcbb1f5ba52c77
Gerrit-Change-Number: 22737
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210208/660cedea/attachment.htm>


More information about the gerrit-log mailing list