This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
laforge gerrit-no-reply at lists.osmocom.orglaforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/22755 ) Change subject: osmo_ortp: Don't print ERROR message for every missing RTP frame ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/c/libosmo-abis/+/22755/1/src/trau/osmo_ortp.c File src/trau/osmo_ortp.c: https://gerrit.osmocom.org/c/libosmo-abis/+/22755/1/src/trau/osmo_ortp.c@209 PS1, Line 209: return 0; > IMHO it would make a lot more sense to have a global counter for this instead, but this chnage as a […] the problem with a global counter is that it has very limited use. You normally constantly have lchans set-up and torn-down, every time that counter would legitimately increase. So if at all, it would be a per-lchan counter, and you would only want to look at its increments after the initial setup and before the final teardown. Even in that case - would we want to put that burden an whatever is processin that counter data externally? I'd say if at all, we'd probably best * start some kind of timer * only count (globally or per-lchan) when that timer has expired * make sure to stop counting early during channel teardown - i.e. "not that simple" -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/22755 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: Ide0017987b4cea7fd24795941494f1da913ea673 Gerrit-Change-Number: 22755 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge at osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-Comment-Date: Mon, 08 Feb 2021 17:19:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin at sysmocom.de> Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210208/a8706001/attachment.htm>