Change in osmo-bts[master]: oml: make 'struct tlv_parsed' pointer const where possible

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

fixeria gerrit-no-reply at lists.osmocom.org
Sat Feb 6 16:07:22 UTC 2021


fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/22762 )


Change subject: oml: make 'struct tlv_parsed' pointer const where possible
......................................................................

oml: make 'struct tlv_parsed' pointer const where possible

Change-Id: I077f5aba50cc4d1a86feff527784de07394c5c0a
---
M src/common/oml.c
1 file changed, 5 insertions(+), 5 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/62/22762/1

diff --git a/src/common/oml.c b/src/common/oml.c
index b7b86e3..b1ae7b4 100644
--- a/src/common/oml.c
+++ b/src/common/oml.c
@@ -1155,7 +1155,7 @@
  * manufacturer related messages
  */
 
-static int oml_ipa_mo_set_attr_nse(void *obj, struct tlv_parsed *tp)
+static int oml_ipa_mo_set_attr_nse(void *obj, const struct tlv_parsed *tp)
 {
 	struct gsm_bts *bts = container_of(obj, struct gsm_bts, gprs.nse);
 
@@ -1178,7 +1178,7 @@
 	return 0;
 }
 
-static int oml_ipa_mo_set_attr_cell(void *obj, struct tlv_parsed *tp)
+static int oml_ipa_mo_set_attr_cell(void *obj, const struct tlv_parsed *tp)
 {
 	struct gsm_bts *bts = container_of(obj, struct gsm_bts, gprs.cell);
 	struct gprs_rlc_cfg *rlcc = &bts->gprs.cell.rlc_cfg;
@@ -1249,7 +1249,7 @@
 }
 
 static int oml_ipa_mo_set_attr_nsvc(struct gsm_bts_gprs_nsvc *nsvc,
-				    struct tlv_parsed *tp)
+				    const struct tlv_parsed *tp)
 {
 	if (TLVP_PRES_LEN(tp, NM_ATT_IPACC_NSVCI, 2))
 		nsvc->nsvci = ntohs(tlvp_val16_unal(tp, NM_ATT_IPACC_NSVCI));
@@ -1319,7 +1319,7 @@
 }
 
 static int oml_ipa_mo_set_attr(struct gsm_bts *bts, const struct gsm_abis_mo *mo,
-				void *obj, struct tlv_parsed *tp)
+				void *obj, const struct tlv_parsed *tp)
 {
 	int rc;
 
@@ -1380,7 +1380,7 @@
 }
 
 static int rx_oml_ipa_rsl_connect(struct gsm_bts_trx *trx, struct msgb *msg,
-				  struct tlv_parsed *tp)
+				  const struct tlv_parsed *tp)
 {
 	struct e1inp_sign_link *oml_link = trx->bts->oml_link;
 	uint16_t port = IPA_TCP_PORT_RSL;

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/22762
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I077f5aba50cc4d1a86feff527784de07394c5c0a
Gerrit-Change-Number: 22762
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210206/50534bcc/attachment.htm>


More information about the gerrit-log mailing list