Change in osmo-ggsn[master]: apn_start: avoid segfault if missing tun-device

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

pespin gerrit-no-reply at lists.osmocom.org
Fri Feb 5 21:27:41 UTC 2021


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/22732 )

Change subject: apn_start: avoid segfault if missing tun-device
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.osmocom.org/c/osmo-ggsn/+/22732/2/ggsn/ggsn_vty.c 
File ggsn/ggsn_vty.c:

https://gerrit.osmocom.org/c/osmo-ggsn/+/22732/2/ggsn/ggsn_vty.c@710 
PS2, Line 710: 		apn->cfg.shutdown = false;
> that's how cisco works: You have all new nodes (e.g. vlans, bridges, ... […]
yes I know, I was talking about the C variable. Most probably because the verb/order "to shut down" also matches the "already shutdown" state naming here.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/22732
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ggsn
Gerrit-Branch: master
Gerrit-Change-Id: I9f71af65cc0eed71728c04b774e5c08352947913
Gerrit-Change-Number: 22732
Gerrit-PatchSet: 2
Gerrit-Owner: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Fri, 05 Feb 2021 21:27:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge at osmocom.org>
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210205/715d9c7c/attachment.htm>


More information about the gerrit-log mailing list