This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
laforge gerrit-no-reply at lists.osmocom.orglaforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22722 )
Change subject: BSSGP_Emulation: Fix warning: control reaches end of non-void function
......................................................................
Patch Set 1:
(1 comment)
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22722/1/library/BSSGP_Emulation.ttcnpp
File library/BSSGP_Emulation.ttcnpp:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22722/1/library/BSSGP_Emulation.ttcnpp@594
PS1, Line 594: setverdict(fail, "No LLC SAPI for ", l3_mo);
: mtc.stop;
: self.stop;
I think the better approach would be to call Misc_Helpers.f_shutdown(fail, ...) in all those cases? or if that is not possible, what about "all component.stop" ? that includes both self and mtc, and is only a single line.
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22722
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I9a44afc81b5b6b35a32a12efcf2dd1cb15e73e12
Gerrit-Change-Number: 22722
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-CC: laforge <laforge at osmocom.org>
Gerrit-Comment-Date: Fri, 05 Feb 2021 20:36:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210205/fde3da46/attachment.htm>