Change in libosmocore[master]: gprs_ns2_sns: add timeout to ST_CONFIG_SGSN

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Fri Feb 5 20:33:47 UTC 2021


laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/22743 )

Change subject: gprs_ns2_sns: add timeout to ST_CONFIG_SGSN
......................................................................


Patch Set 6: Code-Review+1

(1 comment)

https://gerrit.osmocom.org/c/libosmocore/+/22743/6/src/gb/gprs_ns2_sns.c 
File src/gb/gprs_ns2_sns.c:

https://gerrit.osmocom.org/c/libosmocore/+/22743/6/src/gb/gprs_ns2_sns.c@1376 
PS6, Line 1376: 			LOGPFSML(fi, LOGL_ERROR, "NSE %d: Config retries failed. Selecting next IP-SNS endpoint.\n", nse->nsei);
might be nice to ahve the log lines differ from the case above, so that the log indicates something like BSS-originated config procedure or SGSN-originated config procedure.  That way the user doesn't have to check the source code to see what actually failed.



-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/22743
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I2700c1ad40ebe30658e9937d86a4861b0b59d6b6
Gerrit-Change-Number: 22743
Gerrit-PatchSet: 6
Gerrit-Owner: lynxis lazus <lynxis at fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Fri, 05 Feb 2021 20:33:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210205/6746efae/attachment.htm>


More information about the gerrit-log mailing list