This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
lynxis lazus gerrit-no-reply at lists.osmocom.orglynxis lazus has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/22742 ) Change subject: gprs_ns2_sns: rework tracking of NS-VC unblocked/alive state ...................................................................... Patch Set 5: (8 comments) https://gerrit.osmocom.org/c/libosmocore/+/22742/3/src/gb/gprs_ns2_sns.c File src/gb/gprs_ns2_sns.c: https://gerrit.osmocom.org/c/libosmocore/+/22742/3/src/gb/gprs_ns2_sns.c@233 PS3, Line 233: /*! called when a nsvc is beeing freed or the nsvc is become dead */ > is become -> became Ack https://gerrit.osmocom.org/c/libosmocore/+/22742/3/src/gb/gprs_ns2_sns.c@234 PS3, Line 234: void ns2_sns_replace_nsvc(struct gprs_ns2_vc *nsvc) > the naming is not descriptive. […] what do you mean with "handled internally"? https://gerrit.osmocom.org/c/libosmocore/+/22742/3/src/gb/gprs_ns2_sns.c@252 PS3, Line 252: gss->sns_nsvc = tmp; > Shouldn't/couldn't you break on first match? Done https://gerrit.osmocom.org/c/libosmocore/+/22742/3/src/gb/gprs_ns2_sns.c@255 PS3, Line 255: it's > its Done https://gerrit.osmocom.org/c/libosmocore/+/22742/3/src/gb/gprs_ns2_sns.c@259 PS3, Line 259: gss->sns_nsvc = tmp; > break here as well Ack https://gerrit.osmocom.org/c/libosmocore/+/22742/3/src/gb/gprs_ns2_sns.c@893 PS3, Line 893: secs = nsi->timeout[NS_TOUT_TNS_ALIVE] * nsi->timeout[NS_TOUT_TNS_ALIVE_RETRIES] ; > whitespace " ;" Ack https://gerrit.osmocom.org/c/libosmocore/+/22742/3/src/gb/gprs_ns2_sns.c@894 PS3, Line 894: secs *= nsi->timeout[NS_TOUT_TNS_TEST]; > It looks a bit strange multiplying in 2 steps. Ack https://gerrit.osmocom.org/c/libosmocore/+/22742/3/src/gb/gprs_ns2_sns.c@1763 PS3, Line 1763: if (alive == gss->alive) > This if could move before the previous (since gss->alive && !alive would always be false) Ack -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/22742 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ie72da9adeefe0c2850d49a9208b2d0a4556f9101 Gerrit-Change-Number: 22742 Gerrit-PatchSet: 5 Gerrit-Owner: lynxis lazus <lynxis at fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann at sysmocom.de> Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-CC: pespin <pespin at sysmocom.de> Gerrit-Comment-Date: Fri, 05 Feb 2021 17:42:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin at sysmocom.de> Comment-In-Reply-To: daniel <dwillmann at sysmocom.de> Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210205/0072e636/attachment.htm>