This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
fixeria gerrit-no-reply at lists.osmocom.orgfixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22321 )
Change subject: pcu: Rewrite GPRS_Components functions to use pre-decoded RLCMAC blocks coming from PCUIF
......................................................................
Patch Set 3: Code-Review+1
(4 comments)
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22321/3/pcu/GPRS_Components.ttcn
File pcu/GPRS_Components.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22321/3/pcu/GPRS_Components.ttcn@509
PS3, Line 509: alt {
coding style: we usually avoid indention inside the 'alt' statement.
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22321/3/pcu/GPRS_Components.ttcn@516
PS3, Line 516: }
I think we also need a local guard timer here.
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22321/3/pcu/GPRS_Components.ttcn@820
PS3, Line 820: if (do_repeat) {
What's the practical purpose of 'do_repeat' here? I mean, in which case(s) it's useful to pass true?
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22321/3/pcu/GPRS_Components.ttcn@833
PS3, Line 833: out GsmRrMessage rr_imm_ass
For the sake of consistency (at least with as_rx_ptcch()), let's reorder the arguments to make 'rr_imm_ass' first, then 'template GsmRrMessage t_imm_ass', and then all optional ones with default values.
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22321
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Iecc33565fdc673e3499db12a0d4e0587290cfd45
Gerrit-Change-Number: 22321
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Comment-Date: Fri, 05 Feb 2021 17:03:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210205/dc64808c/attachment.htm>