Change in osmo-ttcn3-hacks[master]: pcu: Fix warning: The value returned by function is not used

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

pespin gerrit-no-reply at lists.osmocom.org
Fri Feb 5 11:15:01 UTC 2021


pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22724 )


Change subject: pcu: Fix warning: The value returned by function is not used
......................................................................

pcu: Fix warning: The value returned by function is not used

Change-Id: Iac84facc0041b928f04a5e2d2311dfd9d642c5a9
---
M pcu/PCU_Tests_SNS.ttcn
1 file changed, 8 insertions(+), 8 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/24/22724/1

diff --git a/pcu/PCU_Tests_SNS.ttcn b/pcu/PCU_Tests_SNS.ttcn
index 4fca26e..21e1ed7 100644
--- a/pcu/PCU_Tests_SNS.ttcn
+++ b/pcu/PCU_Tests_SNS.ttcn
@@ -302,14 +302,14 @@
 
 	if (sgsn_originated_reset) {
 		/* Expect BVC-RESET, but ignore it to prevent a race condition of BVC RESETs */
-		var template PDU_NS pdu := tr_NS_UNITDATA(t_SduCtrlB, 0, decmatch tr_BVC_RESET(?, 0, omit));
-		f_ns_exp(pdu);
+		var template PDU_NS pdu_tmpl := tr_NS_UNITDATA(t_SduCtrlB, 0, decmatch tr_BVC_RESET(?, 0, omit));
+		var PDU_NS pdu := f_ns_exp(pdu_tmpl);
 		/* SGSN originated BVC-RESET on an uninitialized signalling BVC */
 		f_tx_bvc_reset_rx_ack(0, omit, omit);
 
 		/* Expect BVC-RESET PTP BVC, but ignore it to prevent a race condition of BVC RESETs */
-		pdu := tr_NS_UNITDATA(t_SduCtrlB, 0, decmatch tr_BVC_RESET(?, mp_gb_cfg.bvc[0].bvci, mp_gb_cfg.bvc[0].cell_id));
-		f_ns_exp(pdu);
+		pdu_tmpl := tr_NS_UNITDATA(t_SduCtrlB, 0, decmatch tr_BVC_RESET(?, mp_gb_cfg.bvc[0].bvci, mp_gb_cfg.bvc[0].cell_id));
+		pdu := f_ns_exp(pdu_tmpl);
 		/* SGSN originated BVC-RESET on an uninitialized PTP BVC */
 		f_tx_bvc_reset_rx_ack(mp_gb_cfg.bvc[0].bvci, omit, mp_gb_cfg.bvc[0].cell_id);
 	} else {
@@ -363,14 +363,14 @@
 
 	if (sgsn_originated_reset) {
 		/* Expect BVC-RESET, but ignore it to prevent a race condition of BVC RESETs */
-		var template PDU_NS pdu := tr_NS_UNITDATA(t_SduCtrlB, 0, decmatch tr_BVC_RESET(?, 0, omit));
-		f_ns_exp(pdu, idx := 1);
+		var template PDU_NS pdu_tmpl := tr_NS_UNITDATA(t_SduCtrlB, 0, decmatch tr_BVC_RESET(?, 0, omit));
+		var PDU_NS pdu := f_ns_exp(pdu_tmpl, idx := 1);
 		/* SGSN originated BVC-RESET on an uninitialized sign BVC */
 		f_tx_bvc_reset_rx_ack(0, omit, omit, idx := 1);
 
 		/* Expect BVC-RESET PTP BVC, but ignore it to prevent a race condition of BVC RESETs */
-		pdu := tr_NS_UNITDATA(t_SduCtrlB, 0, decmatch tr_BVC_RESET(?, mp_gb_cfg.bvc[0].bvci, mp_gb_cfg.bvc[0].cell_id));
-		f_ns_exp(pdu, idx := 1);
+		pdu_tmpl := tr_NS_UNITDATA(t_SduCtrlB, 0, decmatch tr_BVC_RESET(?, mp_gb_cfg.bvc[0].bvci, mp_gb_cfg.bvc[0].cell_id));
+		pdu := f_ns_exp(pdu_tmpl, idx := 1);
 		f_tx_bvc_reset_rx_ack(mp_gb_cfg.bvc[0].bvci, omit, mp_gb_cfg.bvc[0].cell_id, idx := 1);
 	} else {
 		/* Expect BVC-RESET for signaling BVCI=0 */

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22724
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Iac84facc0041b928f04a5e2d2311dfd9d642c5a9
Gerrit-Change-Number: 22724
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210205/2df95074/attachment.htm>


More information about the gerrit-log mailing list