Change in osmo-bts[master]: pcu_sock: pcu_tx_si_all(): fix returning ununitialized rc

[laforge]

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/22691 )

Change subject: pcu_sock: pcu_tx_si_all(): fix returning ununitialized rc
......................................................................

pcu_sock: pcu_tx_si_all(): fix returning ununitialized rc

Change-Id: Ic78614bebade701db14439aa64ecf89c7104a639
Fixes: CID#216932
---
M src/common/pcu_sock.c
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Jenkins Builder: Verified
  laforge: Looks good to me, approved



diff --git a/src/common/pcu_sock.c b/src/common/pcu_sock.c
index d7092f9..250491f 100644
--- a/src/common/pcu_sock.c
+++ b/src/common/pcu_sock.c
@@ -777,7 +777,7 @@
 		if (GSM_BTS_HAS_SI(bts, si_types[i])) {
 			rc = pcu_tx_si(bts, si_types[i], true);
 			if (rc < 0)
-				rc = -EINVAL;
+				return rc;
 		} else {
 			LOGP(DPCU, LOGL_INFO,
 			     "SI%s is not available on PCU connection\n",
@@ -785,7 +785,7 @@
 		}
 	}
 
-	return rc;
+	return 0;
 }
 
 static int pcu_rx_txt_ind(struct gsm_bts *bts,

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/22691
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: Ic78614bebade701db14439aa64ecf89c7104a639
Gerrit-Change-Number: 22691
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210204/5e36b809/attachment.htm>