This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
keith gerrit-no-reply at lists.osmocom.orgkeith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/13421 ) Change subject: Add vty option to globally enable LCLS ...................................................................... Patch Set 15: > Patch Set 15: > > I've stumbled across this old patch. As far as I can see, it makes LCLS disable-able. The question is: Do we wnat that? @keith, do you remember the context of this patch? The context is possibly explained in https://osmocom.org/issues/2487 There were 3 patches in Max's original patchset. This one, the one I voted down, (I don't think we need it) and https://gerrit.osmocom.org/c/osmo-msc/+/13422/18 which is marked WIP but should not be, as I removed the MNCC version change that @neels rightly objected to in the latest patchset. The two proposed patches require further patchsets to become operable which depend on deciding how to encode the LCLS CGR (Global Call Reference) in SIP so that we transfer to/from the SIP connector. Part of these further patch sets (prepared but not yet submitted) bump the MNCC version in both MSC and SIP connector. In forwarding porting this and the other above mentioned patch, I have tried to deviate as little as possible from the original functional changes and intention of Max's patch. - see commit message "That's experimental patch to facilitate _TESTING_ ......" so that they can be merged and then expanded on. As I commented on gerrit 13422, I guess the other option is to abandon this and write a new patchset, but for the moment I decided to leave these and go ahead with the follow up patches that complete the functionality. > > If we merge it, I would rather say it is "permit lcls" than "enable lcls", as whether or not LCLS can be used depends on a lot of other conditions, not just this newly introduced flag. Renaming it works for me. As for whether we want the flag, I think that enable lcls 0 or disable or whatever would then not send the LCLS params on the A interface. Would we want that ever with a 3rd party BSC? -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/13421 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Ibb587e6ae47cff71f5bf2e2d22c1da86cd7e1762 Gerrit-Change-Number: 13421 Gerrit-PatchSet: 15 Gerrit-Owner: Max <suraev at alumni.ntnu.no> Gerrit-Assignee: Hoernchen <ewild at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Max <suraev at alumni.ntnu.no> Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de> Gerrit-Reviewer: keith <keith at rhizomatica.org> Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de> Gerrit-Reviewer: osmith <osmith at sysmocom.de> Gerrit-CC: Hoernchen <ewild at sysmocom.de> Gerrit-Comment-Date: Wed, 03 Feb 2021 21:16:25 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210203/f6b8ff19/attachment.htm>